scaling your code review

• Burgers• “Scaling our Code Reviewing” - Sander Bol• Short break• “What's new in PHP 7?” - Thijs Feryn• Office tour• Drinks

Schedule

Facts

Facts

Facts

Facts

Facts

July 19th 2016 - Behind the ScenesSander Bol

Growth

DefinitionCode Review is the act of consciously and systematically convening with one’s fellow programmers to check each other’s code for mistakesSource: https://smartbear.com/learn/code-review/what-is-code-review/

Code Review is the act of consciously and systematically convening with one’s fellow programmers to check each other’s code for mistakes

Definition

DefinitionCode Review is the act of consciously and systematically convening with one’s fellow programmers to check each other’s code for mistakes

DefinitionCode Review is the act of consciously and systematically convening with one’s fellow programmers to check each other’s code for mistakes

Definition

Definition

Happy accidents?

Common mistakes

What to look for in a review?

● Functionality● Design● Readability & Maintainability● Have you thought about…?

How you should do reviews...

\_(ツ )_/¯

Answer me these questions three...

When to review?

Whatto review?

Whois reviewing?

Pull Request Review

Production

Development

Post-merge Review

Production

Development

What to review

What to review

What to review

Who is reviewing?

?? X

?

✓

✓

!!

X✓

Who is reviewing?

?? X

?

✓

✓

!!

X✓

Indenting!Whitespace!Trailing comma!Bad naming!Low test coverage!Debug code!Insecure code!Does not compile!

Who is reviewing?

?✓ !!

X✓

Indenting!Whitespace!Trailing comma!Bad naming!Low test coverage!Debug code!Insecure code!Does not compile!

Answer me these questions three...

When to review?

Whatto review?

Whois reviewing?

Asking for a review- Start with the obvious

“The goal of my change is...”- Limit size of change set- Reserve time in advance- Implement any feedback you receive (or explain why

not)- Keep your commits clean- All tests green!

3 steps Coolblue took

3 steps Coolblue took

3 steps Coolblue took

ToolingBasic● Pull request (Github / Bitbucket)Advanced● Jetbrains Upsource● Phabricator Differential● Reviewable.io (“Github reviews done right”)● Atlassian Crucible

Remember, remember

1.Start with the obvious.2.Automate the tedious.3.Why so serious?

• Burgers• “Scaling our Code Reviewing” - Sander Bol• Short break• “What's new in PHP 7?” - Thijs Feryn• Office tour• Drinks

Schedule

Untitled Bob Ross painting.

Image credits

http://dogtalk101.blogspot.nl/2011/05/let-sleeping-dogs-lie.html