![Page 1: Four myths about peer code reviews - 7. ebay tech talk](https://reader038.vdocuments.net/reader038/viewer/2022100600/554f58e0b4c905b9508b5264/html5/thumbnails/1.jpg)
7. ebay Tech Talk Berlin
Demystifying Code Reviews with Gerrit Mateusz Szczap Holger Hammel
![Page 2: Four myths about peer code reviews - 7. ebay tech talk](https://reader038.vdocuments.net/reader038/viewer/2022100600/554f58e0b4c905b9508b5264/html5/thumbnails/2.jpg)
• Part of the ebay family • located ebay Campus Dreilinden • Germany’s biggest online marketplace for vehicles • 7.44 million unique users (AGOF 2013-04) • 150 people, 60 within technology • High traffic web, android and iOS applications • Agile cross functional teams
Mateusz Szczap - Software Engineer Holger Hammel - Team Lead mobile
![Page 3: Four myths about peer code reviews - 7. ebay tech talk](https://reader038.vdocuments.net/reader038/viewer/2022100600/554f58e0b4c905b9508b5264/html5/thumbnails/3.jpg)
why this presentation?
some ideas for starting and proceeding with code reviews easier
![Page 4: Four myths about peer code reviews - 7. ebay tech talk](https://reader038.vdocuments.net/reader038/viewer/2022100600/554f58e0b4c905b9508b5264/html5/thumbnails/4.jpg)
Ok nice, but why reviewing at all?
Get feedback for better code
“I believe that peer code reviews are the single biggest thing you can do to improve your code.” [jat]��“Code reviews aren't the ultimate solution to a broken design process, but they are an incredibly useful tool.” [mwe]
![Page 5: Four myths about peer code reviews - 7. ebay tech talk](https://reader038.vdocuments.net/reader038/viewer/2022100600/554f58e0b4c905b9508b5264/html5/thumbnails/5.jpg)
What type of reviews you use?
Pair Programming (by peer, instantly) Peer Code Review (by peer, async) Code Walkthroughs (by group, async)
![Page 6: Four myths about peer code reviews - 7. ebay tech talk](https://reader038.vdocuments.net/reader038/viewer/2022100600/554f58e0b4c905b9508b5264/html5/thumbnails/6.jpg)
Myth 1: come on, reviews are too expensive and slow!
less errors -> more productivity no debugging, retesting, finding the right person, building tech debt
up to 95% defect detection w/ XP (just <60% w/ only automated testing)
Sources: [smc] references various studies
![Page 7: Four myths about peer code reviews - 7. ebay tech talk](https://reader038.vdocuments.net/reader038/viewer/2022100600/554f58e0b4c905b9508b5264/html5/thumbnails/7.jpg)
Myth 2: you have to understand the whole context of what you review
No you haven’t Mentioning a typo or a SOLID or clean code violation or a formatting issue or a missing test or I didn’t find anything or ….. helps
![Page 8: Four myths about peer code reviews - 7. ebay tech talk](https://reader038.vdocuments.net/reader038/viewer/2022100600/554f58e0b4c905b9508b5264/html5/thumbnails/8.jpg)
Myth 3: reviews are blocking
You may not want another column on your board and wait for someone to review Reviews make sense even non-blocking and after a release the faster the better, though
![Page 9: Four myths about peer code reviews - 7. ebay tech talk](https://reader038.vdocuments.net/reader038/viewer/2022100600/554f58e0b4c905b9508b5264/html5/thumbnails/9.jpg)
Myth 4: tools are horrible
yeah, not always a myth make it as simple, convenient and fast as possible to create and finish reviews => for example with gerrit
![Page 10: Four myths about peer code reviews - 7. ebay tech talk](https://reader038.vdocuments.net/reader038/viewer/2022100600/554f58e0b4c905b9508b5264/html5/thumbnails/10.jpg)
Sources • [smc] Steve McConnell: Code Complete, Second Edition; Microsoft
Press; 2004; chapters: 20.3. Relative Effectiveness of Quality Techniques; 20.5. The General Principle of Software Quality; http://www.ebay.de/sch/i.html?_nkw=McConnell%2C+Steve%3A+Code+Complete
• http://scientopia.org/blogs/goodmath/2011/07/06/things-everyone-should-do-code-review/
• [jat] Jeff Atwood: http://www.codinghorror.com/blog/2006/01/code-reviews-just-do-it.html
• [mwe] Matt Welsh: �http://matt-welsh.blogspot.de/2012_02_01_archive.html
• [rbo] Robert Bogue - “Code Reviews w/o the pain”, best practices�http://www.developer.com/tech/article.php/3579756/Effective-Code-Reviews-Without-the-Pain.htm
• [jco] Jason Cohen, Smartbear: “11 proven practices for more effective, efficient peer code review”�http://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/index.html