effective code review dan menard. hi. my name is dan. i work at netflix (tv ui engineer). i’m...

11
Effective Code Review Dan Menard

Upload: louise-conley

Post on 25-Dec-2015

215 views

Category:

Documents


0 download

TRANSCRIPT

Page 1: Effective Code Review Dan Menard. Hi. My name is Dan.  I work at Netflix (TV UI Engineer).  I’m Canadian, but I live in California.  I’m galeophobic

Effective Code ReviewDan Menard

Page 2: Effective Code Review Dan Menard. Hi. My name is Dan.  I work at Netflix (TV UI Engineer).  I’m Canadian, but I live in California.  I’m galeophobic

Hi. My name is Dan. I work at Netflix (TV UI Engineer).

I’m Canadian, but I live in California.

I’m galeophobic.

…and I’m here to talk about code review.

Page 3: Effective Code Review Dan Menard. Hi. My name is Dan.  I work at Netflix (TV UI Engineer).  I’m Canadian, but I live in California.  I’m galeophobic

Everyone should do code review.

Page 4: Effective Code Review Dan Menard. Hi. My name is Dan.  I work at Netflix (TV UI Engineer).  I’m Canadian, but I live in California.  I’m galeophobic

The Benefits of Code Review You write better code when you know it will be reviewed.

A second (or third, or fourth…) set of eyes will help spot defects.

More than one person understands your code.

It’s a great way to learn more about the codebase.

It will make you a better developer.

Page 5: Effective Code Review Dan Menard. Hi. My name is Dan.  I work at Netflix (TV UI Engineer).  I’m Canadian, but I live in California.  I’m galeophobic

What to look (out) for. Bad Design.

Lack of clarity.

Lack of conformity.

Performance hazards.

Page 6: Effective Code Review Dan Menard. Hi. My name is Dan.  I work at Netflix (TV UI Engineer).  I’m Canadian, but I live in California.  I’m galeophobic

What’s not important? Optimization.

Skill and experience gaps.

Personal style.

Page 7: Effective Code Review Dan Menard. Hi. My name is Dan.  I work at Netflix (TV UI Engineer).  I’m Canadian, but I live in California.  I’m galeophobic

Fitting code review into your dev cycle. When should you review code?

What level of persistence do you need?

Should you use a code review tool?

Page 8: Effective Code Review Dan Menard. Hi. My name is Dan.  I work at Netflix (TV UI Engineer).  I’m Canadian, but I live in California.  I’m galeophobic

Code review for geographically dispersed teams. Helps manage asynchronous coding.

Builds a more cohesive codebase.

Gives you a real status update.

Builds trust and morale.

Page 9: Effective Code Review Dan Menard. Hi. My name is Dan.  I work at Netflix (TV UI Engineer).  I’m Canadian, but I live in California.  I’m galeophobic

How to sell code review to others. Not as hard as selling unit tests.

Bottom-up approach.

Just do it.

Page 10: Effective Code Review Dan Menard. Hi. My name is Dan.  I work at Netflix (TV UI Engineer).  I’m Canadian, but I live in California.  I’m galeophobic

Code review is for everyone. Small companies, medium-sized companies, large companies.

Open source and closed source.

Pros or amateurs.

Local or remote.

Solo projects are no exception.

Page 11: Effective Code Review Dan Menard. Hi. My name is Dan.  I work at Netflix (TV UI Engineer).  I’m Canadian, but I live in California.  I’m galeophobic

www.dan-menard.com

[email protected]

@dan_menard