launchpad e code review

33
Agile Business Group - http://www.agilebg.com - [email protected] Launchpad e code review Leonardo Pistone – lep – Agile Business Group

Upload: odoo-italia

Post on 02-Jul-2015

252 views

Category:

Documents


1 download

DESCRIPTION

Come far crescere OpenERP e la localizzazione

TRANSCRIPT

Page 1: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

Launchpad e code review

Leonardo Pistone – lep – Agile Business Group

Page 2: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

● Dedicata a OpenERP dal 2009

● Primi progetti su OpenERP 5.0

● Italia e Svizzera

Chi è Agile BG?

Page 3: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

● Per chi partecipa a OpenERP in Italia

● Per chi vuole partecipare a OpenERP in Italia

● Programmatori

● Non programmatori

Per chi è questo tutorial?

Page 4: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

Linus Torvalds

“Talk is cheap, show me the code”

Page 5: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

“Come faccio a partecipare?”

Page 6: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

1. Perché?2. Come?

Page 7: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

1. Perché?●Win-win

●Abbondanza

●Somma > 0

●Lo sforzo rimane nel tempo

●Chi partecipa è un esperto

Page 8: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

1. Stile libero●Molti esempi di successo

●Regole diverse, confronti difficili

●Attori diversi

●Community Italiana

●OCA

Page 9: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

1. Perché?

https://code.launchpad.net/~icsergio/openobject-italia/remake-vat-registries/+merge/152598

Page 10: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

1. Perché?

“Instead of imagining that our main task is to instruct a computer what to

do, let us concentrate rather on explaining to human beings what we

want a computer to do.”

Don Knuth

Page 11: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

1. Perché?

“Code is read more often than it is written”

Guido Van Rossum

Page 12: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

1. Perché code review?

http://alexgaynor.net/2013/sep/26/effective-code-review/

● Altri umani leggono il diff

● Bus factor

● Leggibilità. Se non c'è, è un baco.

● “Given enough eyeballs, all bugs are shallow” (Raymond)

● Cultura sana e aperta: abitudine alla critica costruttiva

● La discussione stessa rimane e dà valore aggiunto

Page 13: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

2. Come?

“Launchpad is a unique collaboration and hosting platform for software

projects.”

http://launchpad.net/+tour

Page 14: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

2. Come?

1. Utente

http://launchpad.net/+tour

Page 15: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

Page 16: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

2. Come?

2. Team

http://launchpad.net/+tour

Page 17: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

Page 18: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

2. Come?

2. Progetto

Page 19: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

Page 20: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

2. Come?

3. Baco

Page 21: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

Page 22: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

Come riportare un baco● Riprodurre

● Da dove parto?

● Cosa faccio?

● Cosa ottengo?

● Cosa mi aspetto?

● Solo alla fine, facoltativo, che soluzione propongo?

● In un mondo ideale: un test automatico

Page 23: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

2. Come?

4. Branch

Page 24: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

Page 25: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

4. Branch● Proprietario

● Progetto

● Stato

● Serie

● Ultimo commit

● Stacked branch

Page 26: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

2. Come?

5. Merge proposal

Page 27: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

Page 28: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

5. Merge proposal● Da dove?

● A dove?

● Chi?

● Chi approva?

● diff

● Commenti

Page 29: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

2. Come?

6. Finale: Merge!

Page 30: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

Page 31: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

6. Finale: Merge!● bzr info

● bzr status

● bzr merge

● bzr commit

● bzr push

● (caffé)

● Effetti su baco, branch, MP

Page 32: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

7. Direzione

Page 33: Launchpad e code review

Agile Business Group - http://www.agilebg.com - [email protected]

8. Grazie!