sepo training - code review & design review by amanda

SEPO Training - Code Review & Design Review

by Amanda

Confidential and proprietary Copyright 2011

/ TELENAV GPS NavigatorAlways Find Your Way!/

Independent Code Review

Design Review by System

Agenda



Process of Independent Code Review

Assign ReviewerOwner: PJM

Create Task on JIRAOwner: Reviewer

Assign to DEV Lead

Sign Reviewer’s Name on Release NoteOwner: DEV Lead

Code ReadyOwner: DEV Lead

Studio – Code FreezeOthers – 1st Submission

Cross Component, Cross Team, Cross Group; Senior Engineer\\fs1\Program Office\Quality\Reviewers for Independent Code Review

Accept and Revieww/o IntroductionOwner: Reviewer

Review Comments Only(Necessary comments in the corresponding place; Refer to Coding Standard)

Code Review MeetingOwner: Reviewer & DEV Lead

Accept the build by Checking Release Note

Owner: QA

Resolved the Taskby DEV Lead

1. Meeting is recommended, but not mandatory.2. Reviewer shares thoughts with developers.



For PJM



Assign to DEV Lead









Owner: QA





For DEV Lead



Assign to DEV Lead









Owner: QA


1. Meeting is recommended, but not mandatory.2. Reviewer shares thoughts with developers.3. Reviewer calls it.



For Reviewer



Assign to DEV Lead









Owner: QA





For QA



Assign to DEV Lead









Owner: QA





Design Review by System

Ask for ReviewMail to Rong Xing

Owner: PJM

Introduction and Q&A MeetingOwner: PJM / DEV / System / QA

FSD/Design Doc ReadyOwner: DEV

Rong Xing will schedule the meeting.Reviewed Content:1. Architecture Review2. Finalize Key Function Point

Studio – Review before CodingOthers – At least ONCE in 3 months

For Studio Project, like 7.1, 7.2, Main Components are enough.

Assign 2 Reviewers foreach ComponentOwner: Rong Xing

Slides PreparationOwner: DEV

Sign Reviewers’ Name and Review Date on Release Note

Owner: DEV Lead

Accept the build by Checking Review Date is within 3 months

Owner: QA (from Apr 1st)

Create Task on JIRAOwner: System

Assign to DEV Lead




For PJM


Owner: PJM









Owner: DEV Lead




Assign to DEV Lead




For DEV


Owner: PJM









Owner: DEV Lead




Assign to DEV Lead




For System


Owner: PJM









Owner: DEV Lead




Assign to DEV Lead




For QA


Owner: PJM









Owner: DEV Lead




Assign to DEV Lead




http://spaces.telenav.com:8080/display/programoffice/Independent+Code+Review

http://spaces.telenav.com:8080/display/programoffice/Design+Review+by+System

Official Wiki







Thanks!

sepo training - code review & design review by amanda

Documents